Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scaffold): use default values.yaml #1891

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

olblak
Copy link
Member

@olblak olblak commented Jan 25, 2024

This pullrequest replaces generate the default values file using values.yaml instead of values.d/default.yaml.
In the process I also renamed a few variable to be more consistent with other similar variables.

A scaffolded policy looks like

.
├── CHANGELOG.md
├── Policy.yaml
├── README.md
├── updatecli.d
│   └── default.yaml
└── values.yaml

Test

To test this pull request, you can run the following commands:

 cd pkg/core/scaffold/
go test .
go build -o bin/updatecli .
./bin/updatecli manifest init /tmp/test2/
# Verify 

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added the bug Something isn't working label Jan 25, 2024
@olblak olblak added this to the 0.72.0 milestone Jan 25, 2024
@olblak olblak enabled auto-merge (squash) January 25, 2024 11:04
@olblak olblak merged commit adc2292 into updatecli:main Jan 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant