Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix listing helm chart versions #1893

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

galal-hussein
Copy link
Contributor

Fix #1892

reverse the order of listing the helm chart versions from the index file

Test

To test this pull request, you can run the following commands:
1- build the code
2- run the following source

sources:
  jenkins:
    kind: helmchart
    spec:
      url: https://charts.jenkins.io
      name: jenkins
      versionfilter:
        kind: "regex"

OR

sources:
  jenkins:
    kind: helmchart
    spec:
      url: https://charts.jenkins.io
      name: jenkins
      versionfilter:
        kind: "latest"

you should see that source has fetched the latest version

@dduportal dduportal added bug Something isn't working resource-helm labels Jan 26, 2024
Copy link
Member

@olblak olblak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested the pullrequest and it works as expected

+++++++++++
+ PREPARE +
+++++++++++

WARNING: Updatecli binary version is unset. This means you are using a development version that ignores manifest version constraint.

SCM repository retrieved: 0


++++++++++++++++++
+ AUTO DISCOVERY +
++++++++++++++++++



++++++++++++
+ PIPELINE +
++++++++++++



###########
# TT.YAML #
###########


SOURCES
=======

latest
------
Searching for version matching pattern "latest"
✔ Helm Chart "jenkins" version "4.12.1" is found from repository "https://charts.jenkins.io"

Remark: We couldn't identify a way to automatically retrieve changelog information.
Please use following information to take informed decision

Helm Chart: jenkins
Jenkins - Build great things at any scale! The leading open source automation server, Jenkins provides over 1800 plugins to support building, deploying and automating any project.
Project Home: https://jenkins.io/

Version created on the 2024-01-25 00:09:03.29969836 +0000 UTC

Sources:

* https://github.com/jenkinsci/jenkins

* https://github.com/jenkinsci/docker-inbound-agent

* https://github.com/maorfr/kube-tasks

* https://github.com/jenkinsci/configuration-as-code-plugin



URL:

* https://github.com/jenkinsci/helm-charts/releases/download/jenkins-4.12.1/jenkins-4.12.1.tgz




CHANGELOG:
----------

Remark: We couldn't identify a way to automatically retrieve changelog information.
Please use following information to take informed decision

Helm Chart: jenkins
Jenkins - Build great things at any scale! The leading open source automation server, Jenkins provides over 1800 plugins to support building, deploying and automating any project.
Project Home: https://jenkins.io/

Version created on the 2024-01-25 00:09:03.29969836 +0000 UTC

Sources:

* https://github.com/jenkinsci/jenkins

* https://github.com/jenkinsci/docker-inbound-agent

* https://github.com/maorfr/kube-tasks

* https://github.com/jenkinsci/configuration-as-code-plugin



URL:

* https://github.com/jenkinsci/helm-charts/releases/download/jenkins-4.12.1/jenkins-4.12.1.tgz




regex
-----
Searching for version matching pattern ".*"
✔ Helm Chart "jenkins" version "4.12.1" is found from repository "https://charts.jenkins.io"

Remark: We couldn't identify a way to automatically retrieve changelog information.
Please use following information to take informed decision

Helm Chart: jenkins
Jenkins - Build great things at any scale! The leading open source automation server, Jenkins provides over 1800 plugins to support building, deploying and automating any project.
Project Home: https://jenkins.io/

Version created on the 2024-01-25 00:09:03.29969836 +0000 UTC

Sources:

* https://github.com/jenkinsci/jenkins

* https://github.com/jenkinsci/docker-inbound-agent

* https://github.com/maorfr/kube-tasks

* https://github.com/jenkinsci/configuration-as-code-plugin



URL:

* https://github.com/jenkinsci/helm-charts/releases/download/jenkins-4.12.1/jenkins-4.12.1.tgz




CHANGELOG:
----------

Remark: We couldn't identify a way to automatically retrieve changelog information.
Please use following information to take informed decision

Helm Chart: jenkins
Jenkins - Build great things at any scale! The leading open source automation server, Jenkins provides over 1800 plugins to support building, deploying and automating any project.
Project Home: https://jenkins.io/

Version created on the 2024-01-25 00:09:03.29969836 +0000 UTC

Sources:

* https://github.com/jenkinsci/jenkins

* https://github.com/jenkinsci/docker-inbound-agent

* https://github.com/maorfr/kube-tasks

* https://github.com/jenkinsci/configuration-as-code-plugin



URL:

* https://github.com/jenkinsci/helm-charts/releases/download/jenkins-4.12.1/jenkins-4.12.1.tgz




semver
------
Searching for version matching pattern "*"
✔ Helm Chart "jenkins" version "4.12.1" is found from repository "https://charts.jenkins.io"

Remark: We couldn't identify a way to automatically retrieve changelog information.
Please use following information to take informed decision

Helm Chart: jenkins
Jenkins - Build great things at any scale! The leading open source automation server, Jenkins provides over 1800 plugins to support building, deploying and automating any project.
Project Home: https://jenkins.io/

Version created on the 2024-01-25 00:09:03.29969836 +0000 UTC

Sources:

* https://github.com/jenkinsci/jenkins

* https://github.com/jenkinsci/docker-inbound-agent

* https://github.com/maorfr/kube-tasks

* https://github.com/jenkinsci/configuration-as-code-plugin



URL:

* https://github.com/jenkinsci/helm-charts/releases/download/jenkins-4.12.1/jenkins-4.12.1.tgz




CHANGELOG:
----------

Remark: We couldn't identify a way to automatically retrieve changelog information.
Please use following information to take informed decision

Helm Chart: jenkins
Jenkins - Build great things at any scale! The leading open source automation server, Jenkins provides over 1800 plugins to support building, deploying and automating any project.
Project Home: https://jenkins.io/

Version created on the 2024-01-25 00:09:03.29969836 +0000 UTC

Sources:

* https://github.com/jenkinsci/jenkins

* https://github.com/jenkinsci/docker-inbound-agent

* https://github.com/maorfr/kube-tasks

* https://github.com/jenkinsci/configuration-as-code-plugin



URL:

* https://github.com/jenkinsci/helm-charts/releases/download/jenkins-4.12.1/jenkins-4.12.1.tgz




=============================

REPORTS:



- TT.YAML:
	Source:
		✔ [latest] 
		✔ [regex] 
		✔ [semver] 

Run Summary
===========
Pipeline(s) run:
  * Changed:	0
  * Failed:	0
  * Skipped:	1
  * Succeeded:	0
  * Total:	1

using this manifest

sources:
  semver:
    kind: helmchart
    spec:
      url: https://charts.jenkins.io
      name: jenkins
      versionfilter:
        kind: "semver"
  regex:
    kind: helmchart
    spec:
      url: https://charts.jenkins.io
      name: jenkins
      versionfilter:
        kind: "regex"
  latest:
    kind: helmchart
    spec:
      url: https://charts.jenkins.io
      name: jenkins
      versionfilter:
        kind: "latest"

@olblak olblak merged commit 3f542dd into updatecli:main Jan 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resource-helm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm versionfilter fetches oldest version instead of latest when using latest or regex versionfilter
3 participants