Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker Build/Push #190

Merged
merged 5 commits into from
Mar 3, 2021
Merged

Fix Docker Build/Push #190

merged 5 commits into from
Mar 3, 2021

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Mar 3, 2021

The last release v0.1.0 failed to build the Docker image: https://github.com/updatecli/updatecli/runs/2014386430?check_suite_focus=true.

This PR aims at fixing these issues, following the work done in #188 .

It introduces the following changes:

  • Introduce a build arg to the docker image to specify the make target to use in the "builder" image. It defaults to build on a PR, but should be build.all on a tagged build (need to be tested with a tag build)
  • Build the Docker images even on Pull Requests to catch build errors earlier (the condition of "push image if not a pull request is already present)
  • Disable the arm build which was failing the release: the goal would be to improve the build process in the future and re-enable arm

…lier

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal changed the title Build Docker Image without push for pull requests to catch issues ear… Fix Docker Build/Push Mar 3, 2021
…in a PR

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal marked this pull request as ready for review March 3, 2021 10:13
@olblak olblak added the bug Something isn't working label Mar 3, 2021
@olblak olblak merged commit 90c44b0 into updatecli:main Mar 3, 2021
@dduportal dduportal deleted the fix/docker-image branch October 19, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants