Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kubernetes autodiscovery #1928

Merged
merged 6 commits into from
Feb 14, 2024

Conversation

olblak
Copy link
Member

@olblak olblak commented Feb 13, 2024

Add an Autodiscovery plugin to automate container update in Kubernetes manifest update.
By default this plugin will automatically add digest such as

TARGETS
========

dotnet
------

**Dry Run enabled**

⚠ - change detected:
	* key "$.spec.containers[1].image" should be updated from "\"mcr.microsoft.com/dotnet/framework/sdk:3.5\"" to "mcr.microsoft.com/dotnet/framework/sdk:3.5@sha256:2dce56dc4d638ee804a4ee0321617c64b7e127653c5c71dbbcad5c31753eacaf", in file "PodTemplates.d/package-windows.yaml"

Test

To test this pull request, you can run the following commands:

cd cd pkg/plugins/autodiscovery/kubernetes/
go test

Additional Information

Tradeoff

Potential improvement

Compared to other autodiscovery plugin handling containers, this one add additionnal behavior that would be nice for the plugin dockerfile, docker-compose, and helm

  1. Add digest to tag by default
  2. Update digest when using the format mcr.microsoft.com/dotnet/framework/sdk:3.5@sha256:2dce56dc4d638ee804a4ee0321617c64b7e127653c5c71dbbcad5c31753eacaf

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added this to the 0.73.0 milestone Feb 13, 2024
@olblak olblak added enhancement New feature or request autodiscovery All things related to the autodiscovery feature plugin-kubernetes labels Feb 13, 2024
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak self-assigned this Feb 13, 2024
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak merged commit 110a043 into updatecli:main Feb 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autodiscovery All things related to the autodiscovery feature enhancement New feature or request plugin-kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant