Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dockercompose autodiscovery handles digest #1932

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

olblak
Copy link
Member

@olblak olblak commented Feb 15, 2024

Similar pullrequest than #1931

Now by default the Dockercompose autodiscovery plugin will insert a digest unless the parameter digest is set to false.
This feature now allows the following update

  • updatecli/updatecli:latest to updatecli/updatecli:latest@sha256xxxx
  • updatecli/updatecli:0.23.0 to updatecli/updatecli:0.73.0@sha256xxx
  • updatecli/updatecli:0.73.0@sha256xxx to updatecli/updatecli:0.73.0@sha256yyy

I also took the opportunity to update the generated template for using conventional commits messages like

deps(dockercompose): bump image "updatecli/updatecli" digest

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/autodiscovery/dockercompose/
go test .

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added enhancement New feature or request autodiscovery All things related to the autodiscovery feature docker-compose labels Feb 15, 2024
@olblak olblak added this to the 0.73.0 milestone Feb 15, 2024
@olblak olblak merged commit 323d6e2 into updatecli:main Feb 16, 2024
6 checks passed
@olblak olblak deleted the enhancement/dockercompose/digest branch February 16, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autodiscovery All things related to the autodiscovery feature docker-compose enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant