Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: helm autodiscovery handles digest #1938

Merged
merged 5 commits into from
Feb 16, 2024

Conversation

olblak
Copy link
Member

@olblak olblak commented Feb 16, 2024

Similar pullrequest than #1931

Now by default the Helm autodiscovery plugin will insert a digest for container update unless the parameter digest is set to false.
This feature now allows the following update

updatecli/updatecli:latest to updatecli/updatecli:latest@sha256xxxx
updatecli/updatecli:0.23.0 to updatecli/updatecli:0.73.0@sha256xxx
updatecli/updatecli:0.73.0@sha256xxx to updatecli/updatecli:0.73.0@sha256yyy

I also took the opportunity to update the generated template for using conventional commits messages like

deps(helm): bump image "updatecli/updatecli" digest for chart "sample"

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/autodiscovery/helm
go test
go build -o bin/updatecli .
./bin/updatecli diff --config e2e/updatecli.d/success.d/autodiscovery/helm

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added the enhancement New feature or request label Feb 16, 2024
@olblak olblak added autodiscovery All things related to the autodiscovery feature resource-helm labels Feb 16, 2024
@olblak olblak added this to the 0.73.0 milestone Feb 16, 2024
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak merged commit 2f38736 into updatecli:main Feb 16, 2024
6 checks passed
@olblak olblak deleted the enhancement/helm/digest branch April 3, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autodiscovery All things related to the autodiscovery feature enhancement New feature or request resource-helm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant