Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add flux autodiscovery plugin #1950

Merged
merged 19 commits into from
Feb 26, 2024
Merged

feat: add flux autodiscovery plugin #1950

merged 19 commits into from
Feb 26, 2024

Conversation

olblak
Copy link
Member

@olblak olblak commented Feb 21, 2024 •
edited

add flux autodiscovery plugin.
Support updating helm chart specified in helmrelease configuration and oci tag in ocirepository configuration.

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/autodiscovery/flux/
go test .

Additional Information

Tradeoff

Potential improvement

  • Adding support for gitrepository

@olblak
feat: add flux autodiscovery plugin
5242bf1 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added enhancement New feature or request autodiscovery All things related to the autodiscovery feature labels Feb 21, 2024
@olblak olblak marked this pull request as draft February 21, 2024 19:40
bigkevmcd
bigkevmcd reviewed Feb 22, 2024
View reviewed changes
pkg/plugins/autodiscovery/flux/utils_test.go Outdated Show resolved Hide resolved
pkg/plugins/autodiscovery/flux/utils.go Outdated Show resolved Hide resolved
pkg/plugins/autodiscovery/flux/ocirepository.go Show resolved Hide resolved
pkg/plugins/autodiscovery/flux/ocirepository.go Outdated Show resolved Hide resolved
pkg/plugins/autodiscovery/flux/helmrepository.go Outdated Show resolved Hide resolved
pkg/plugins/autodiscovery/flux/main.go Outdated Show resolved Hide resolved
olblak and others added 10 commits February 22, 2024 12:59
@olblak
fix: remove duplicated variable declaration
aa8c3eb 
Signed-off-by: Olblak <me@olblak.com>
@olblak
fix: don't call unnecessary string function
9df6409 
Signed-off-by: Olblak <me@olblak.com>
@olblak
fix: use logrus instead of fmt.Print
60f46ce 
Signed-off-by: Olblak <me@olblak.com>
@olblak
core: use appropriate error function
fe8ab33 
Signed-off-by: Olblak <me@olblak.com>
@olblak
fix: add file endline
4003d7d 
Signed-off-by: Olblak <me@olblak.com>
@olblak
fix(spelling): add worlds to allow.txt
dfdb321 
Signed-off-by: Olblak <me@olblak.com>
@olblak
fix(spelling): add few more words
f9af07c 
Signed-off-by: Olblak <me@olblak.com>
@olblak
feat: use fluxcd api
769eeef 
Signed-off-by: Olblak <me@olblak.com>
@olblak
Merge branch 'main' into enhancement/autodiscovery/flux
c9d96ce
@olblak
fix(spelling): add gvk to allow.txt
7965186 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak mentioned this pull request Feb 23, 2024
Merged
@olblak
chore: use multiline comment with //
9fa2731 
Signed-off-by: Olblak <me@olblak.com>
@olblak
feat: allow to opt in/out helmrelease and ociregistry
bed97a3 
Signed-off-by: Olblak <me@olblak.com>
@olblak
feat: make matchinrule setting more generic
f2ee51d 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added this to the 0.74.0 milestone Feb 23, 2024
@olblak
fix(spelling): rename ocirepository
d181766 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak marked this pull request as ready for review February 23, 2024 19:40
@olblak
fix: update flux e2e tests
0cfc751 
Signed-off-by: Olblak <me@olblak.com>
@olblak
fix(spelling): add kyverno to allow.txt
3e2b3bb 
Signed-off-by: Olblak <me@olblak.com>
@olblak
Merge remote-tracking branch 'upstream/main' into enhancement/autodis…
d73a021 
…covery/flux
@olblak
chore: various cleanup
c024d44 
Signed-off-by: Olblak <me@olblak.com>
@olblak
Copy link
Member Author

olblak commented Feb 26, 2024

Thanks @bigkevmcd for the reviews. It think it's should be fine to start with the current implementation

@olblak olblak merged commit 8fa83bc into updatecli:main Feb 26, 2024
6 checks passed
@olblak olblak deleted the enhancement/autodiscovery/flux branch February 26, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigkevmcd bigkevmcd bigkevmcd left review comments

Assignees
No one assigned
Labels
autodiscovery All things related to the autodiscovery feature enhancement New feature or request
Projects
None yet
Milestone
0.74.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olblak @bigkevmcd