Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to enable/disable working branch for all scm plugins #1955

Merged
merged 13 commits into from
Mar 1, 2024

Conversation

olblak
Copy link
Member

@olblak olblak commented Feb 24, 2024

Fix #1139

Test

To test this pull request, you can execute any manifest with the workingbranch set to false or true:

./bin/updatecli apply --config updatecli/updatecli.d/golangci-lint.yaml --push=false
cd /tmp/updatecli/github/updatecli/updatecli 
git branch # should show main if workingbranch set to true

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added scm-github SCM of type GiHhub scm-git SCM of kind "Git" scm-gittea scm-gitlab scm-stash enhancement New feature or request labels Feb 24, 2024
@olblak olblak added this to the 0.75.0 milestone Feb 24, 2024
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak removed this from the 0.75.0 milestone Feb 26, 2024
@olblak olblak enabled auto-merge (squash) March 1, 2024 18:06
@olblak olblak merged commit c52db43 into updatecli:main Mar 1, 2024
6 checks passed
@olblak olblak deleted the issue/1139 branch April 3, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scm-git SCM of kind "Git" scm-github SCM of type GiHhub scm-gitlab scm-gittea scm-stash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Missing feature parity with github/gitea and git SCMs
1 participant