-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add conditional Target #1962
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to conditionally execute target if `disablecondition` is true then we ignore condition result for that target if `conditionids` has at least one valid `conditionid` then we only monitor that condition result Signed-off-by: Olblak <me@olblak.com>
olblak
added
enhancement
New feature or request
core
All things related to Updatecli core engine
labels
Feb 27, 2024
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Note that this pullrequest will allow to have interesting Updatecli scenario like for handling GitHub action workflow updatecli.yaml
Console Output
|
Signed-off-by: Olblak <me@olblak.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1385
Allow to conditionally execute target.
if
disablecondition
is true then we ignore condition result for that target ifconditionids
has at least one validconditionid
then we only monitor that condition resultTest
To test this pull request, you can run the following commands:
go build -o bin/updatecli . ./bin/updatecli diff --config e2e/updatecli.d/success.d/conditionalTarget.yaml
Command Output
Additional Information
Tradeoff
Potential improvement