refactor: remove useless git checkout after a git clone #1966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1964
I released that we always run git checkout the default branch(main) after a git clone operation.
even though a git checkout is done before each source/condition/targets
This initial git checkout seems useless and generate error in some situation
We can easily reproduce the problem with the following manifests
updatecli.yaml
triggers
Console Output
As updatecli tries to run a git checkout of the default branch "main" which doesn't exist on that repository
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement