Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: execute actions once all pipelines have been executed #2040

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

olblak
Copy link
Member

@olblak olblak commented Apr 19, 2024

  • execute actions once all pipelines have been executed
  • split long function into multiple small ones
  • don't execute similar action multiple times

Fix #2039

Test

Tested on https://github.com/olblak/kubernetes-marketplace/pulls

Additional Information

Tradeoff

Potential improvement

This pullrequest open the door for the potential improvements

  • Execute git push operation once all pipelines have been executed
  • Execute "pre-action" combined with always execution target in diff mode

* execute actions once all pipelines have been executed
* split long function into multiple small ones

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added bug Something isn't working core All things related to Updatecli core engine labels Apr 19, 2024
@olblak olblak added this to the 0.76.0 milestone Apr 19, 2024
@olblak olblak self-assigned this Apr 19, 2024
@olblak olblak marked this pull request as draft April 19, 2024 11:41
@olblak olblak marked this pull request as ready for review April 24, 2024 08:31
@olblak olblak merged commit d764e61 into updatecli:main Apr 24, 2024
6 checks passed
@olblak olblak deleted the issue/2039 branch April 24, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core All things related to Updatecli core engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github pullrequest are re-created if when not needed
1 participant