Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First get changelog information before applying transformers to the source value #208

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

olblak
Copy link
Member

@olblak olblak commented Apr 2, 2021

In the default behavior, updatecli tries to guess changelog information using the value returned from a source.
There is a bigger chance that this initial value can be used to retrieve changelog information than once it has been transformed for later stages.

Thanks, @dduportal for identifying this issue

Btw I still have some plan to define a changelog configuration to customize the way we retrieve changelog information as described in this issue #159

Signed-off-by: Olivier Vernin olivier@vernin.me

Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak olblak added the bug Something isn't working label Apr 2, 2021
@olblak olblak requested a review from dduportal April 2, 2021 13:15
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@olblak olblak merged commit 49fba17 into updatecli:main Apr 2, 2021
@olblak olblak deleted the changelogIssues branch April 2, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants