Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(maven): support unmarshalling maven responses in other XML charsets #2147

Merged
merged 1 commit into from
May 7, 2024
Merged

feat(maven): support unmarshalling maven responses in other XML charsets #2147

merged 1 commit into from
May 7, 2024

Conversation

mcwarman
Copy link
Member

@mcwarman mcwarman commented May 6, 2024 •
edited

Fix #2146

Add support for Maven repositories that contain XML encoding other than UTF-8.

Create decoder based on charset configured in XML reader

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/utils/mavenmetadata
go test
sources:
  latest:
    kind: maven
    spec:
      repository: "https://plugins.gradle.org/m2/"
      groupid: "io.freefair.gradle"
      artifactid: "lombok-plugin"

@mcwarman mcwarman force-pushed the feature/maven-xml-encoding branch from 87ba97a to 31e68e9 Compare May 6, 2024 20:32
@mcwarman
feat(maven): support unmarshalling maven responses in other XML charsets
aba4fef 
Create and use decoder based on charset configured in XML reader
@mcwarman mcwarman force-pushed the feature/maven-xml-encoding branch from 31e68e9 to aba4fef Compare May 6, 2024 21:07
@mcwarman mcwarman changed the title feat(maven): add support for other charsets when decoding feat(maven): support unmarshalling maven responses in other XML charsets May 6, 2024
@olblak olblak modified the milestones: 0.76.0, 0.77.0 May 7, 2024
@olblak olblak added enhancement New feature or request resource-mavenrepository Resource of kind Maven Repository resource-xml Modify resource of type xml labels May 7, 2024
@olblak olblak merged commit b495968 into updatecli:main May 7, 2024
6 checks passed
@mcwarman mcwarman deleted the feature/maven-xml-encoding branch May 7, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olblak olblak olblak approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request resource-mavenrepository Resource of kind Maven Repository resource-xml Modify resource of type xml
Projects
None yet
Milestone
0.77.0
Development

Successfully merging this pull request may close these issues.

Maven plugin encoding support
2 participants
@mcwarman @olblak