Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run git checkout before autodiscovery step #2160

Merged
merged 7 commits into from
May 11, 2024

Conversation

olblak
Copy link
Member

@olblak olblak commented May 11, 2024

This pullrequest fix a racing issue where Updatecli generates autodiscover pipeline based on the default branch as it didn't checkout the branch specified by the scm configuration.

Then generated pipeline correctly update the branch specified by the scm configuration

Test

To test this pull request, you can run the following commands:

cd <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

@olblak olblak added bug Something isn't working autodiscovery All things related to the autodiscovery feature labels May 11, 2024
@olblak olblak added this to the 0.77.0 milestone May 11, 2024
@olblak olblak enabled auto-merge (squash) May 11, 2024 19:00
@olblak olblak disabled auto-merge May 11, 2024 19:01
@olblak olblak enabled auto-merge (squash) May 11, 2024 19:01
@olblak olblak changed the title Fix/autodiscovery/scm/checkout fix: run git checkout before autodiscovery step May 11, 2024
@olblak olblak merged commit 23eac12 into updatecli:main May 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autodiscovery All things related to the autodiscovery feature bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant