Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Add "git push --force" to scm resource #221

Merged
merged 6 commits into from
Apr 26, 2021

Conversation

olblak
Copy link
Member

@olblak olblak commented Apr 21, 2021

In the current stage, we always push commits/tags using the --force parameter.
I propose the parameter force which can be specified at the Github/git level to enable or disable that behavior with the default behavior set to no force push which is a breaking change compared to the current situation.

Signed-off-by: Olivier Vernin olivier@vernin.me

Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak olblak added the enhancement New feature or request label Apr 21, 2021
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Do'nt forget to prefix the PR's title with BREAKING: because it's a breaking change ;)

@olblak olblak changed the title Add git push --force parameter BREAKING:: Add git push --force parameter Apr 21, 2021
@olblak olblak changed the title BREAKING:: Add git push --force parameter BREAKING: Add git push --force parameter Apr 21, 2021
@olblak olblak merged commit a721d64 into updatecli:main Apr 26, 2021
@olblak olblak changed the title BREAKING: Add git push --force parameter BREAKING: Add "git push --force" to scm resource May 2, 2021
@olblak olblak deleted the forcePush branch August 30, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants