-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runtime templating in configuration #242
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
dduportal
added a commit
to dduportal/updatecli
that referenced
this pull request
Jul 8, 2021
This reverts commit b07e0e6.
olblak
pushed a commit
that referenced
this pull request
Jul 8, 2021
olblak
added a commit
that referenced
this pull request
Jul 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to partially fix #158 and superseded #181
Runtime templating
It allows templating configuration based on runtime information.
The function "pipeline" accepts one parameter where the value corresponds to a updatecli configuration key, a value where the key is case insensitive.
which can be defined like:
title: {{ pipeline "Source.Output" }}
sources:
default:
name: Get Latest helm release version
kind: githubRelease
spec:
owner: "helm"
repository: "helm"
token: {{ requiredEnv .github.token }}
username: olblak
version: latest
The configuration is updated after each stage, if it finds a function configuration value set to pipeline "updatecli_config", then it tries to replace with a value but only if the value exists otherwise it keeps pipeline "updatecli_config" for the next run .
While working on this PR, I took the following shortcuts
pipeline
can't be used for [sources, conditions, target] map key such assources.default.result
should becomecontext.sources.default.result
Depends_on
A
depends_on
key can be use to specify resources dependencies within a stage.So in the following example the depends_on assume that we have another source with the id "weekly"
otherwise we fail the pipeline
Errors
In case of a dependency loop detected, we return the following error
In case of a wrong depends_on
Signed-off-by: Olivier Vernin olivier@vernin.me