-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add username/password parameter for Docker Registry authentication #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Vernin <olivier@vernin.me>
GITHUB_TOKEN doesn't work with bearer token which is a serious regression, I need to investigate other options |
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Improve validation function Signed-off-by: Olivier Vernin <olivier@vernin.me>
Improve validation function Signed-off-by: Olivier Vernin <olivier@vernin.me>
Correctly return when needed Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
olblak
changed the title
Switch ghcr.io auth from token to bearer
Fix Docker Registry authentication
Jul 6, 2021
Signed-off-by: Olivier Vernin <olivier@vernin.me>
It seems that secrets are not available from the runner |
Run quick test in pull request Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
olblak
changed the title
Fix Docker Registry authentication
Add username/password parameter for Docker Registry authentication
Jul 7, 2021
Credentials required for the test are not available from github action running for pull request so I am introduce short test and long test to only execute short tests from PR runner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #245
For some reason, the previous authentication mechanism using Token doesn't work anymore and changing to bearer like other registry works
This pull request refactor docker registry authentication, we should now specific a username and password parameter when we need to authenticate with a docker registry such as
Remark
Credentials required for the new test are not available from Github Action triggered by pull request from fork repository so I am introducing short test and long test to only execute short tests in such cases
Signed-off-by: Olivier Vernin olivier@vernin.me