Feat: enable distribution with homebrew #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
feat/homebrew
branch
from
3683263
to
03ac134
Compare
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
feat/homebrew
branch
from
03ac134
to
51553f4
Compare
|
This PR sounds good to me, @dduportal how confident do you feel with this one? Should we wait for a specific release with this one? |
olblak
approved these changes
Oct 4, 2021
|
@olblak I cannot be sure that it will work at the first try. I've tried as much as possible locally, I propose that (if it is ok for your review of course) we merge it, then proceed to release 0.8.0 (as it will allow to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #154 (this PR is the last mile)
This PR enables distribution of updatecli through an homebrew tam.
It follows the goreleaser's homebrew documentation and the official homebrew tap maintainer documentation.
The repository updatecli/hombrew-updatecli had been created (empty) to hosts the formula with the homebrew default convention naming.
Test
We have to perform a release to end-2-end validate.
Once a release will be performed after merging this PR, then a macOS user will be able to install updatecli with:
Additionnal Information
Tradeoff
Potential improvement