-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat [Shell]: Add an attribute which suppress the source appending #304
Conversation
Documentation PR (from @jplayout also): updatecli/website#140 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT 👍
Thank you a lot @jplayout for the PR. I am thinking of something like:
And we could just have a condition that test if disableSourceInput is set to true then we set the source to an empty string |
@olblak WDYT about merging this PR (eventually adapting the attribute name) to target a delivery for the The reason is because we tagged the issue #288 to be first good issue, and we are exteding the scope now that the PR is open... ;) |
Thats weird: I never clicked the merge button, neither did I enable the auto-merge 😕 |
weird that the pr got merged anyway you made a good suggestion, I need to think a little bit about my suggestion and both are not incompatible. So let's move forward. I would just target a new minor version instead of a patch version |
Add an attribute which suppress the source appending
Fix #288
I added an boolean attribute named suppressSource which removes the source added to the command