Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix [shell] correct error reporting when a condition execution fails #320

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Oct 19, 2021

Before the fix

stderr and stdout where inverted when using a shell condition that failed:

CONDITIONS:
===========

The shell 🐚 command "./examples/updateCli.generic/shell/condition.sh 2.5.1-FreeBSD" failed with an exit code of 1 and the following messages: 
stderr=

stdout=
+ ls /titi
ls: /titi: No such file or directory


βœ— condition not met, skipping pipeline

=============================

After the fix

CONDITIONS:
===========

The shell 🐚 command "./examples/updateCli.generic/shell/condition.sh 2.5.1-FreeBSD" failed with an exit code of 1 and the following messages: 
stderr=
+ ls /titi
ls: /titi: No such file or directory

stdout=


βœ— condition not met, skipping pipeline

=============================

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal added bug Something isn't working condition Modify condition resource resource-shell Resource of kind Shell labels Oct 19, 2021
@dduportal dduportal requested a review from olblak October 19, 2021 08:40
@olblak olblak enabled auto-merge (squash) October 19, 2021 08:44
@olblak olblak merged commit 1d90b67 into updatecli:main Oct 19, 2021
@dduportal dduportal deleted the bugfix/shell-report branch October 19, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working condition Modify condition resource resource-shell Resource of kind Shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants