Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix [file,yaml] correct path resolution when using scm for file and yaml resources #324

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

dduportal
Copy link
Contributor

This PR fixes a bug introduces in #318 which broke the file and yaml resources when used with an SCM.

@dduportal dduportal added bug Something isn't working target Related to updatecli target source condition Modify condition resource resource-yaml Resource of kind YAML resource-file Resource of kind File labels Oct 20, 2021
@dduportal dduportal requested a review from olblak October 20, 2021 15:12
…aml resources

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Copy link
Member

@olblak olblak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

@olblak olblak merged commit e8a92cf into updatecli:main Oct 20, 2021
@dduportal dduportal deleted the fix/file-yaml-errors branch November 11, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working condition Modify condition resource resource-file Resource of kind File resource-yaml Resource of kind YAML source target Related to updatecli target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants