fix(dockerfile) ensure that there is only 1 Dockerfile with all required tools #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
changed the title
…red tools Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
fix/dockerimage-tools
branch
from
e9681f4
to
121a3bd
Compare
dduportal
changed the title
|
@olblak if this PR works as expected, I should be able to release a 0.11.1 (patch only as it would have no feature) |
olblak
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the
Dockerfilerelated logic to ensure that there is only 1Dockerfile:make docker.*targets (not used anymore since we rely on goreleaser)Dockerfile.releasetoDockerfile+ associated changes:updatecli/Dockerfile(as the tools such ascurlorwgetare absent from the latest 0.11.0 image release)