-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support labels configuration for Github Pull Request #350
Conversation
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good ! Code review is ok for me (only nitpicking comments).
Haven't tried a lot of cases, let's see ho it behaves.
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
Thanks for reviewing, coming days will be pretty busy for me so I am planning to merge this PR after Wednesday |
Support labels configuration for Github Pull Request
Fix #108
! This pull request introduces some refactoring to automatically re-opened a pull request in a closed.
Allow specifying a new block configuration "pullrequest" via updatecli config.
All settings in the pullRequest are optional!
labels - Allow specifying labels when creating a new pullrequest.
! labels must already exist otherwise they are just
Test
To test this pull request, you can run the following commands:
Additionnal Information
Tradeoff
Considering that we can have different parameters to configure a new pullRequest, I decided to have a specific block for better clarity.
Potential improvement
Allow specifying assignee/project