Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transformer findSubMatch #356

Merged
merged 3 commits into from
Nov 11, 2021
Merged

Add transformer findSubMatch #356

merged 3 commits into from
Nov 11, 2021

Conversation

olblak
Copy link
Member

@olblak olblak commented Nov 11, 2021

Add transformer findSubMatch

Fix #280

The purpose of this transformer is to use a regex to extract a substring

Test

To test this pull request, you can run the following commands:

  cp pkg/core/transformer
  go test

Additionnal Information

Tradeoff

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added the transformers Related to transformers label Nov 11, 2021
@dduportal dduportal added the enhancement New feature or request label Nov 11, 2021
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job ! LGTM

@olblak olblak enabled auto-merge (squash) November 11, 2021 16:56
@olblak olblak merged commit 27b2ee4 into updatecli:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request transformers Related to transformers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new transformers "findSubmatch"
2 participants