Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(file) improve Diff output when a file is changed #370

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

dduportal
Copy link
Contributor

Fix #369

Example of output:

pdateGroovyCode
----------------

**Dry Run enabled**

✔ File content for "/var/folders/2s/09szbrgn22l2tcvxz1_k34g40000gn/T/updatecli/jenkins-infra/pipeline-library/vars/buildDockerAndPublishImage.groovy", updated. 

--- /var/folders/2s/09szbrgn22l2tcvxz1_k34g40000gn/T/updatecli/jenkins-infra/pipeline-library/vars/buildDockerAndPublishImage.groovy
+++ /var/folders/2s/09szbrgn22l2tcvxz1_k34g40000gn/T/updatecli/jenkins-infra/pipeline-library/vars/buildDockerAndPublishImage.groovy
@@ -33,7 +33,7 @@
       ),
       containerTemplate(
         name: 'next-version',
-        image: config.nextVersionImage ?: 'ghcr.io/jenkins-x/jx-release-version:2.4.13',
+        image: config.nextVersionImage ?: 'ghcr.io/jenkins-x/jx-release-version:2.5.1',
         command: 'cat',
         ttyEnabled: true,
         resourceRequestCpu: '200m',
         ```

## Test

To test this pull request, you can run the following commands:

```shell
cp <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Copy link
Member

@olblak olblak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the output improvement, and it could probably be applied to other places as well

@olblak olblak merged commit 24f8427 into updatecli:main Nov 13, 2021
@olblak olblak added this to the 0.14.1 milestone Nov 13, 2021
@dduportal dduportal deleted the enhancement/file-diff branch November 17, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement Request: improvie diff for file targets
2 participants