Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yaml) report target as failed when the key is not found instead of a false positive #380

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Nov 17, 2021

Fix #379

Logic flaw in the YAML file's target. Unit test had to be updated to catch this one

Tested with the example of the associated issue:

TARGETS
========

imageTag
--------

**Dry Run enabled**

ERROR: Something went wrong in target "imageTag" :
ERROR: ✗ cannot find key 'image.tag' from file '/var/folders/2s/09szbrgn22l2tcvxz1_k34g40000gn/T/updatecli/dduportal/charts/config/wiki.yaml'


=============================

REPORTS:


✔ WIKI.YAML:
        Sources:
                ✔ [latestRelease] Get latest jenkins-infra/docker-confluence-data release(githubRelease)
        Condition:
                ✔ [docker] Test jenkinsciinfra/wiki:<latest_version> docker image tag(dockerImage)
        Target:
                ✗ [imageTag]  Update wiki docker image tag(yaml)
                ```

@dduportal dduportal added bug Something isn't working resource-yaml Resource of kind YAML target Related to updatecli target labels Nov 17, 2021
@dduportal dduportal added this to the 0.15.0 milestone Nov 17, 2021
…f a false positive

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal merged commit 865d59f into updatecli:main Nov 18, 2021
@dduportal dduportal deleted the gh-379 branch November 18, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resource-yaml Resource of kind YAML target Related to updatecli target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[yaml] Target with a key not found does not reports as a failure
1 participant