fix(log messages) homogenize the emojis used for user output messages #386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a "short term" fix to ensure that the log messages have the same behavior and all use the same emoji.
It also improve code readability as it's easier to understand the constant
result.ATTENTION
than\u26A0
.Please note the following changes:
result
, when a variable had a conflicting name then it had been changes (3 occurends, 2 are in the AMI package)result
packageFAILURE
orSUCCESS
statesFAILURE
orSUCCESS
statesFAILURE
indicates a real error, whileSUCCESS
is used when nothing had been changed, andATTENTION
when a change is expected (diff) or applied (apply).Please note that a long term fix is to implement a custom
logger
package that would provide explicit method such asValidationErrorLog()
,SuccessErrorLog()
,ContentChangedLog()
,FailureLog()
etc. to move the multiple usages of emojis to a central place, and get rid of theresult
package.