fix(conditions) prints validation error when found #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for a bug I found while working on #289 .
It ensures that the validation error messages are printed to the end user when a condition failed to be validated.
Test
With a manifest having the following condition (missing
spec.file
)With updatecli 0.16.0, you got:
# ... CONDITIONS: =========== checkUsername ------------- ✗ condition not met, skipping pipeline
=> result is expected but no message to help the end user.
With this PR, you got:
=> which is clearly an improvement
Additional Information
Tradeoff
Potential improvement