Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github) open a new pullrequest if the previous were closed #426

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Dec 20, 2021

(e.g. do not query GitHub API for closed PRs)

Co-authored with @olblak to fix #424.

Test

Tested on https://github.com/dduportal/docker-builder/pulls?q=is%3Apr

Additional Information

Tradeoff

Potential improvement

…do not query GitHub API for closed PRs)

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Co-authored-by: Olblak <me@olblak.com>
@dduportal dduportal added bug Something isn't working pullrequest-github labels Dec 20, 2021
@dduportal dduportal enabled auto-merge (rebase) December 20, 2021 20:01
@dduportal dduportal merged commit 0d67982 into updatecli:main Dec 20, 2021
@dduportal dduportal deleted the fix/gh-424 branch December 20, 2021 20:19
@olblak olblak modified the milestone: 0.17.1 Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pullrequest-github
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in 0.17.0: Github PullRequest is not open
2 participants