Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pullrequest) show the correct report for the pull request section #427

Merged
merged 1 commit into from
Dec 21, 2021
Merged

fix(pullrequest) show the correct report for the pull request section #427

merged 1 commit into from
Dec 21, 2021

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Dec 20, 2021 •
edited

  • Print a message by default when the dry run is used (and keep the debug detailed output)
  • Do no print "Nothing left <...>" and proceed to opening/update Pull Requests when
    the targets reports "succeeded" (e.g. not changed). Closes Wrong pullrequest message #421
  • Fix a typo on GitHub Pull Request log output

Signed-off-by: Damien Duportal damien.duportal@gmail.com
Co-authored-by: Olblak me@olblak.com

Fix #421

With https://github.com/dduportal/docker-builder/blob/main/updatecli/updatecli.d/ghcli.yml

  • Result in "diff" mode:
PULL REQUESTS
=============

[Dry Run] A Pull Request is expected (with kind "github" and title "[updatecli] Bump ghcli version").
  • Result in "diff" mode with debug:
PULL REQUESTS
=============

[Dry Run] A Pull Request is expected (with kind "github" and title "[updatecli] Bump ghcli version").
DEBUG: The expected Pull Request would have the following informations:
        |
        |       ##Title:
        |       [updatecli] Bump ghcli version
        |
        |       ##Changelog:
        |
        |
        |       Release published on the 2021-12-02 18:04:53 +0000 UTC at the url https://github.com/cli/cli/releases/tag/v2.3.0
...

@dduportal @olblak
fix(pullrequest) show the correct report for the pull request section
7d399bb 
- Print a message by default when the dry run is used (and keep the debug detailed output)
- Do no print "Nothing left <...>" and proceed to opening/update Pull Requests when
  the targets reports "succeeded" (e.g. not changed). Closes updatecli#421
- Fix a typo on GitHub Pull Request log output

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Co-authored-by: Olblak <me@olblak.com>
@dduportal dduportal marked this pull request as draft December 21, 2021 07:57
olblak
olblak approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@olblak olblak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@olblak olblak added bug Something isn't working pullrequest-github labels Dec 21, 2021
@olblak olblak self-assigned this Dec 21, 2021
@olblak olblak marked this pull request as ready for review December 21, 2021 08:23
@olblak olblak merged commit 806404d into updatecli:main Dec 21, 2021
@dduportal dduportal deleted the fix/gh-421 branch December 21, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olblak olblak olblak approved these changes

Assignees

@olblak olblak

Labels
bug Something isn't working pullrequest-github
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong pullrequest message
2 participants
@dduportal @olblak