Bugfix: Don't try to open a pullrequest when not needed

[olblak]

Signed-off-by: Olblak me@olblak.com

Don't try to open a pullrequest when not needed

Fix #431

Add a function to test if the latest commits of two branches are similar. The intend of this approach is to only try to create a pullrequest when two branch content mismatch

Test

To test this pull request, you can run the following commands:

cp pkg/plugins/git/generic
go test

Additional Information

Tradeoff

Potential improvement

I am planning to also look at a way to test if two git tags are similar

[olblak]

Well for some reason the github action doesn't find the branch "main"

[olblak]

I successfully tested this PR with jenkins-infra/kubernetes-management#1879
But I can't figure out why the test is not working from Github Action

[dduportal]

The error also appears on my machine (macOS 12.1, MBP 16" Intel, go1.17.5):

$ gh pr checkout 436
$ make test-short    
go test ./... -short
# ...
time="2022-01-02T09:27:53+01:00" level=error msg="reference \"main\" - reference not found"
time="2022-01-02T09:27:53+01:00" level=error msg="reference \"main\" - reference not found"
time="2022-01-02T09:27:53+01:00" level=error msg="reference \"main\" - reference not found"
--- FAIL: TestIsSimilarBranch (0.00s)
    main_test.go:54: 
                Error Trace:    main_test.go:54
                Error:          Not equal: 
                                expected: *errors.errorString(&errors.errorString{s:"reference not found"})
                                actual  : <nil>(<nil>)
                Test:           TestIsSimilarBranch
    main_test.go:55: [0] Expected error '<nil>' but got 'reference not found'
    main_test.go:54: 
                Error Trace:    main_test.go:54
                Error:          Not equal: 
                                expected: *errors.errorString(&errors.errorString{s:"reference not found"})
                                actual  : <nil>(<nil>)
                Test:           TestIsSimilarBranch
    main_test.go:55: [1] Expected error '<nil>' but got 'reference not found'
    main_test.go:61: 
                Error Trace:    main_test.go:61
                Error:          Not equal: 
                                expected: false
                                actual  : true
                Test:           TestIsSimilarBranch
    main_test.go:62: [1] Expected result 'true' but got 'false'
FAIL
FAIL    github.com/updatecli/updatecli/pkg/plugins/git/generic  7.026s
#...

=> I'm trying to debug it since it appears locally.

[dduportal]

The fix is working for me on both the asciidoctor/docker-asciidoctor and jenkins-infra/* repositories on my manual tests ✅ .

Many thanks for this huge work to start 2022 🍾

[dduportal]

🚀