Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pullrequests) validate that specified targets exist in the manifest #447

Merged
merged 3 commits into from
Jan 12, 2022

Conversation

dduportal
Copy link
Contributor

Fix #442

Test

To test this pull request, create the following manifest:

title: Bump Golang Version

scms:
  default:
    kind: github
    spec:
      user: updatecli
      email: me@olblak.com
      owner: updatecli
      repository: updatecli
      token: 'SuperSecretToken'
      branch: main

sources:
  latestVersion:
    name: Get Latest Version
    kind: shell
    spec:
      command: echo 1.0.0

targets:
  release-sandbox:
    name: 'Update last version'
    sourceID: latestVersion
    kind: shell
    spec:
      command: echo
    scmID: default

pullrequests:
  default:
    title: 'PR Title Here'
    kind: github
    scmID: default
    targets:
      - foo

you can run the following commands:

go build -o ./dist/updatecli && ./dist/updatecli diff --config manifest.yaml

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@olblak olblak modified the milestone: 0.19.0 Jan 12, 2022
@olblak olblak enabled auto-merge (squash) January 12, 2022 11:10
@olblak olblak merged commit 6169f4f into updatecli:main Jan 12, 2022
@dduportal dduportal deleted the gh-442 branch January 14, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pullrequest-github target Related to updatecli target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull Request does not check for existence of specified target items
2 participants