chore(release) use a temporary token from GH app to fix homebrew deployment #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oyment Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
added
chore
cleanup
github_actions
olblak
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a "merge-back" of the release https://github.com/updatecli/updatecli/releases/tag/v0.17.3 that solved the homebrew issue.
It features the switch from a Personal Access Token to a GitHub Application to allow the homebrew publication.
It's the same method as for the workflow
updatecli: a github app at organization level is defined,and we use a github action to generate a temporary token, valid for the duration of the release build only.
Test
To test this pull request, you have to trigger a new release (v0.18.1) ?
Additional Information
Tradeoff
Potential improvement