fix(helm) correct error unsupported protocol scheme ""
#459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
changed the title
unsupported protocol scheme ""
dduportal
added
bug
olblak
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #458
Sounds like I messed up the helm chart plugin in #437.
This PR fixes it by adding the necessary New() constructor method (otherwise it was not initialized).
Tested on https://github.com/jenkins-infra/kubernetes-management/tree/main/updatecli/updatecli.d/charts manifests with success.
Test
To test this pull request, you can run the following commands:
go build -o ./dist/updatecli && ./dist/updatecli --debug diff --config examples/updatecli.generic/helmChartAdditional Information
Tradeoff
Potential improvement