hotfix(conditions) show error message when a condition errors #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
lemeurherve
reviewed
Jan 16, 2022
lemeurherve
reviewed
Jan 16, 2022
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
lemeurherve
approved these changes
Jan 16, 2022
olblak
approved these changes
Jan 17, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not usre when this "misbehavior" was introduced but currently, conditions that fails because of an error does not show the error message.
It's not really convenient, particularly when it is a validation error 馃槄
This PR fixes the print of error message (minor cleanups around happy path / string comparisons)
Test
To test this pull request, you can run the following commands:
make build make test make test-e2eAdditional Information
Tradeoff
Potential improvement