Fix deprecated example in README #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
olblak
commented
Feb 16, 2022
•
olblak
commented
- Fix deprecated example in README
- Minor README improvement
lemeurherve
reviewed
Feb 16, 2022
lemeurherve
reviewed
Feb 16, 2022
lemeurherve
reviewed
Feb 16, 2022
lemeurherve
reviewed
Feb 16, 2022
lemeurherve
reviewed
Feb 16, 2022
lemeurherve
reviewed
Feb 16, 2022
lemeurherve
reviewed
Feb 16, 2022
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
lemeurherve
reviewed
Feb 16, 2022
lemeurherve
reviewed
Feb 16, 2022
lemeurherve
reviewed
Feb 16, 2022
lemeurherve
reviewed
Feb 16, 2022
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Signed-off-by: Olblak <me@olblak.com>
lemeurherve
previously approved these changes
Feb 17, 2022
dduportal
reviewed
Feb 17, 2022
dduportal
reviewed
Feb 17, 2022
dduportal
reviewed
Feb 17, 2022
dduportal
reviewed
Feb 17, 2022
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
Fix wording as suggested by Herve Signed-off-by: Olblak <me@olblak.com>
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
|
Waiting for someone to review and merge |
lemeurherve
approved these changes
Feb 17, 2022
| conditions: | ||
| docker: | ||
| name: "Docker Image Published on Registry" | ||
| name: "Test if Docker Image Published on Registry" |
There was a problem hiding this comment.
Suggested change
| name: "Test if Docker Image Published on Registry" | |
| name: Test if Docker Image Published on Registry |
(Last line with ")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.