fix: log the config name at validation

[lemeurherve]

Fixes #536

Log the config name (which default value is the manifest filename) so when updacli is running on a folder and there is an error it's easier to know which manifest has a problem.

Test

To test this pull request, you can run the following commands:

cp <to_package_directory>
go test

Additional Information

Tradeoff

One additional line per manifest in the output

Potential improvement (and fix of the tradeoff)

This log should even replace the one line 82:

updatecli/pkg/core/config/main.go

Line 82 in 01da81e

logrus.Infof("Loading Pipeline %q", cfgFile)

WDYT? In that case, this PR could be "fix: log the config name at validation instead of at loading"

[lemeurherve]

WDYT? In that case, this PR could be "fix: log the config name at validation instead of at loading"

@olblak I wanted to include it in this PR but waited for your return before doing so. No worry I can do it in another PR, but I'd still like to hear your opinion before :)

IMO it would be better as it would simply replace the current log line done when the files are loaded by one done when each file is validated.

[olblak]

Sorry that I missed your question, I should have take more care before merging your pullrequest.

IMHO the message from line 82 logrus.Infof("Loading Pipeline %q", cfgFile) contains a different information than the pipeline name so it makes sense to have it. We want to easily identify what went wrong when trying to read the file.

Your PR is about identifying what went wrong when validating the pipeline from the file

For a reason that I ignore the line 105 is duplicated with 114. The line 105 should be removed.

Imho your change should have been a debug and not an info.

thinking loud
I am wondering if it wouldn't be better to notify which pipeline we are in from the engine package

updatecli/pkg/core/engine/main.go

Line 145 in 5afdcfb