Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make title and message pretty #54

Merged
merged 2 commits into from
Jul 1, 2020
Merged

make title and message pretty #54

merged 2 commits into from
Jul 1, 2020

Conversation

jetersen
Copy link
Member

@jetersen jetersen commented Jun 29, 2020

This works out great.
Here you got the updated commit message:

[updatecli] Update external-dns version to 2.20.4

Key 'versions.externalDns', from file 'system-services/helm/values.yaml', was updated to '2.20.4'

Not sure making name required is desired or not but for my use-case it works.

I was thinking of taking the name from source if none is supplied but it became cumbersome changeset.
for maven you would use artifactId and github release you would use repository
for docker you would use imageName and helm chart you would use chart name

WDYT?

image

@jetersen
Copy link
Member Author

jetersen commented Jul 1, 2020

@olblak would be great if you could review it :)

somewhat blocked by #55

@olblak
Copy link
Member

olblak commented Jul 1, 2020

That's really great, thanks for the PR

@olblak olblak added the enhancement New feature or request label Jul 1, 2020
@olblak olblak merged commit 9b78dc3 into updatecli:master Jul 1, 2020
@jetersen jetersen deleted the fix/title-message branch July 1, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants