Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Authentication Bug with Private Git Repos #557

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

hi-artem
Copy link
Contributor

Fix for Authentication Bug with Private Git Repos

As it is right now, authentication with Private Git Repo is not working properly. It can be replicated by trying to make a pullrequest to a private repository.

The following PR adds Auth property to all the methods supporting AuthOptions in Checkout method.

Test

plugins/utils/gitgeneric on  feature/auth-checkout via 🐹 v1.17.5 on ☁️  (us-west-2)
❯ go test

PASS
ok  	github.com/updatecli/updatecli/pkg/plugins/utils/gitgeneric	4.447s

Additional Information

Tradeoff

n/a

@olblak
Copy link
Member

olblak commented Mar 10, 2022

Thanks @hi-artem for the contribution. It looks very good to me. Let me test it before merging

@olblak olblak added the bug Something isn't working label Mar 10, 2022
@olblak olblak self-requested a review March 10, 2022 07:36
@olblak
Copy link
Member

olblak commented Mar 10, 2022

While testing the pullrequest, I spot #558
I need to open a pullrequest with a fix (which I have locally)

Also to test the pullrequest, I wrote a updatecli.yaml which I now need to commit in the directory e2e so we catch the current regression in the futur

@olblak olblak merged commit 77cc073 into updatecli:main Mar 10, 2022
@olblak olblak added the scm-git SCM of kind "Git" label Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scm-git SCM of kind "Git"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants