Resource "File" correctly uses scmID

[olblak]

Fix #558

If a relative file path is provided with a scmID, then like for condition and target, we want to use the git repository directory as the file root directory

Test

To test this pull request, I used the following updatecli configuration:

.updatecli.yaml

---
title: "Test Git scm"

scms:
  scenario-1:
    kind: git 
    spec:
      username: '{{ requiredEnv "UPDATECLI_GITHUB_ACTOR" }}'
      password: '{{ requiredEnv "UPDATECLI_GITHUB_TOKEN" }}'
      url: "https://github.com/updatecli/experiment.git"
      branch: "main"

sources:
  scenario-1:
    name: "Scenario 1"
    kind: file
    scmID: scenario-1
    spec:
      file: README.md
      line: 1

updatecli diff --config updatecli.yaml

Additional Information

Tradeoff

/

Potential improvement

/

[dduportal]

Good catch!

Can you:

• rebase against master (to only embed the commits related to this PR). easier to review.
• Add unit test(s) to cover the new code block
  ?

[olblak]

@dduportal I had to slightly modify the test struct

[dduportal]

@olblak you did not "slightly change" the test struct: you fixed it as it was incorrect (I don't know how did I mess it up, but it's fix with your change). Thanks!

[olblak]

@olblak you did not "slightly change" the test struct: you fixed it as it was incorrect (I don't know how did I mess it up, but it's fix with your change). Thanks!

Well, you did a great job for those UT, that was just a minor mistake which to be honest confused me initially :D