[jsonschema] Avoid directory collusion when fetching updatecli comments #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olblak <me@olblak.com>
lemeurherve
reviewed
Apr 7, 2022
Signed-off-by: Olblak <me@olblak.com>
lemeurherve
approved these changes
Apr 7, 2022
dduportal
approved these changes
Apr 7, 2022
olblak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olblak me@olblak.com
Avoid directory when fetching updatecli comments
For the command
updatecli jsonschemato populate the field "description", we cloned the updatecli directory in a temporary location and then we delete the directory once we are done. For some stupid reason I was using "/tmp/updatecli" which is also used by default by the scm resource to manipulate git repository. So I ended up in a situation where I deleted/tmp/updateclibefore any git operation to happen.
Test
To test this pull request, I used this configuration https://github.com/updatecli/website/blob/master/updatecli/updatecli.d/jsonschema.yaml
Additional Information
Tradeoff
Potential improvement
In the future, we have a risk of collusion if at some point we have a git repository "github.com/_comments/"