Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return an error when no file has been changed #636

Merged
merged 2 commits into from
Apr 12, 2022
Merged

fix: return an error when no file has been changed #636

merged 2 commits into from
Apr 12, 2022

Conversation

lemeurherve
Copy link
Member

fix: return an error when no file has been changed

Part of #632

Supersede #634

Test

To test this pull request, you can run the following commands:

cp <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

@lemeurherve lemeurherve mentioned this pull request Apr 12, 2022
Closed
@lemeurherve lemeurherve added bug Something isn't working target Related to updatecli target labels Apr 12, 2022
dduportal
dduportal approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dduportal dduportal merged commit d2e513e into updatecli:main Apr 12, 2022
@lemeurherve lemeurherve deleted the is632-fix-report branch January 30, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

@olblak olblak Awaiting requested review from olblak

Assignees
No one assigned
Labels
bug Something isn't working target Related to updatecli target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lemeurherve @dduportal @lemeurherveCB