Add helm dependency management #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olblak <me@olblak.com>
Minor code refactoring Signed-off-by: Olblak <me@olblak.com>
olblak
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add helm dependency management
git commit -Awhen commiting files, otherwise it doesn't include delete filesIf updatecli modifies chart dependencies, then we need a way to regenerate the Chart.lock and download any artifact in the charts directory
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
I had to change the git commit behavior to run
git commit -Aso I can also remove files deleted by the dependency updateConsidering the Updatecli works from a clean work-tree, I am not expecting side effects but 馃し馃従
Potential improvement
I did some quickly exploration for #463 but I couldn't identify a way that wouldn't imply scm changes