Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github) initialize the headbranch #717

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Jun 12, 2022

Fix the issue introduced in #700 (ref. #700 (comment))

Test

To test this pull request, you can run the following commands:

make test
make test-e2e

Also tested on jenkins-infra/kubernetes-management

Additional Information

  • Added unit tests to underline the error before fixing
  • Fixed a typo
  • Removed the pointer/references to the pipelineID string. Not sure the reason why pointer was used?

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal marked this pull request as ready for review June 12, 2022 20:05
@dduportal dduportal requested a review from olblak June 12, 2022 20:06
@dduportal dduportal added bug Something isn't working scm-github SCM of type GiHhub labels Jun 12, 2022
Copy link
Member

@olblak olblak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, this PR didn't seam to be easy to work on

@dduportal dduportal merged commit e2726e0 into updatecli:main Jun 13, 2022
@dduportal dduportal deleted the fix/github-refbranch branch June 13, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scm-github SCM of type GiHhub
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants