Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updatecli manifest for golang update #719

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

olblak
Copy link
Member

@olblak olblak commented Jun 15, 2022

Signed-off-by: Olblak me@olblak.com

Fix updatecli manifest for golang update

I noticed that the pipeline that update Golang version is broken
This PR is the fix needed to get it back on track

 - GOLANG.YAML:
	Sources:
		✔ [gomod] Update go.mod (kind: shell)
		✔ [latestGoVersion] Get Latest Go Release (kind: githubrelease)
	Condition:
		✔ [dockerTag] Is docker image golang:1.18.3 published (kind: dockerimage)
		✔ [workflowgo] Ensure GA step is defined in Github Action named go (kind: yaml)
		✔ [workflowrelease] Ensure GA step is defined in Github Action named release (kind: yaml)
		✔ [workflowrelease-sandbox] Ensure GA step is defined in Github Action named release-sandbox (kind: yaml)
		✗ [workflowupdatecli] [release.yaml] Update Golang version to 1.18.3 (kind: yaml)
	Target:
		- [go.mod] [go.mod] Update Golang version to {{ source "latestGoVersion" }} (kind: file)
		- [release] [release-sandbox.yaml] Update Golang version to {{ source "latestGoVersion" }} (kind: yaml)
		- [release-sandbox] [release.yaml] Update Golang version to {{ source "latestGoVersion" }} (kind: yaml)
		- [workflowgo] [release.yaml] Update Golang version to {{ source "latestGoVersion" }} (kind: yaml)
		- [workflowupdatecli] [release.yaml] Update Golang version to {{ source "latestGoVersion" }} (kind: yaml)

Test

To test this pull request, you can run the following commands:

updatecli diff --config updatecli/updatecli.d/golang.yaml 

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak merged commit 5ddf7c1 into updatecli:main Jun 15, 2022
@olblak olblak deleted the updatecliGAWorkflow branch June 15, 2022 12:17
@olblak
Copy link
Member Author

olblak commented Jun 15, 2022

Oups I merged a bit quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants