Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if the extension is not yaml and not yml #732

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

kuisathaverat
Copy link
Contributor

check if the extension is not yaml and not yml

Fix #731

Test

To test this pull request, you can run the following commands:

cat >EOF > pipeline.yml 
---
title: Update test values
sources:
  dummy:
    name: "Dummy"
    kind: shell
    spec:
      command: echo {{ .Value }}
targets:
  dummy:
    name: "Dummy"
    kind: shell
    spec:
      command: echo {{ .Value }}
EOF
cat <EOF > values.yml
Value: "foo"
EOF
cp pipeline.yml pipeline.yaml
cp values.yml values.yaml 
go run main.go diff --config pipeline.yml --values values.yml
go run main.go diff --config pipeline.yaml --values values.yml
go run main.go diff --config pipeline.yml --values values.yaml
go run main.go diff --config pipeline.yaml --values values.yaml

Additional Information

Tradeoff

Potential improvement

Copy link
Member

@olblak olblak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

@olblak olblak enabled auto-merge (squash) June 24, 2022 18:57
@olblak olblak added the bug Something isn't working label Jun 24, 2022
@olblak olblak merged commit 8b01aa6 into updatecli:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Values file is not accepted
2 participants