Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Report shouldn't show source and target if none were configured #746

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

olblak
Copy link
Member

@olblak olblak commented Jul 1, 2022

Signed-off-by: Olblak me@olblak.com

Report shouldn't show source and target if none were configured

Fix a small UI bug where we always display the word "source" and "target" in the report information.
For example running updatecli against the following manifest

scms:
  default:
    kind: git 
    spec:
      url: https://github.com/updatecli/updatecli.git

shows

=============================

REPORTS:


- EXAMPLE.YAML:
	Sources:
	Target:



Run Summary
===========
Pipeline(s) run:
  * Changed:	0
  * Failed:	0
  * Skipped:	1
  * Succeeded:	0
  * Total:	1

and should return

=============================

REPORTS:


- EXAMPLE.YAML:

Run Summary
===========
Pipeline(s) run:
  * Changed:	0
  * Failed:	0
  * Skipped:	1
  * Succeeded:	0
  * Total:	1

Test

To test this pull request, you can run updatecli using the manifest mentioned above

Additional Information

Tradeoff

Potential improvement

@olblak olblak added bug Something isn't working reports labels Jul 1, 2022
@olblak olblak requested a review from dduportal July 1, 2022 18:01
@olblak olblak enabled auto-merge (squash) July 1, 2022 18:01
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@olblak olblak merged commit ab7c7b0 into updatecli:main Jul 1, 2022
@olblak olblak added this to the 0.28.0 milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reports
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants