Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Empty changelog message shouldn't display source object even in debug mode #747

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

olblak
Copy link
Member

@olblak olblak commented Jul 1, 2022

Signed-off-by: Olblak me@olblak.com

Empty changelog message shouldn't display source object even in debug mode

Fix #XXX

Empty changelog message shouldn't display source object even in debug mode. It had little value and is a risk for leaking information

Test

To test this pull request, you can run the following commands:

cp <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak enabled auto-merge (squash) July 1, 2022 18:05
@dduportal dduportal added the bug Something isn't working label Jul 1, 2022
@olblak olblak merged commit 66c84c3 into updatecli:main Jul 1, 2022
@olblak olblak added this to the 0.28.0 milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants