feat: Don't clean temporary updatecli directory by default #793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olblak me@olblak.com
Fix #788
Test
To test this pull request, you can run the following commands
updatecli diff
orupdatecli apply
with scm configuration. At the end of the run, we should still see content in /tmp/updatecli/Additional Information
Tradeoff
Enduser will have to clean the temporary directory on themself which is handle by the system anyway as mentioned @gionn
Potential improvement