Fix: Do not update Helm Chart dependencies in dryrun mode #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix metadata file in none scm mode Signed-off-by: Olivier Vernin <olivier.vernin@suse.com>
olblak
added
bug
olblak
changed the title
olblak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olivier Vernin olivier.vernin@suse.com
Fix #XXX
While working on #763, I noticed that we always try to update metadata information even in drymode. Also I noticed that when used locally we tried to update an "empty" chart
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement